Skip to content

async_hooks: prevent async storage methods leaking to outer context#31950

Closed
Qard wants to merge 2 commits intonodejs:masterfrom
Qard:async-storage-eliminate-exit-transition
Closed

async_hooks: prevent async storage methods leaking to outer context#31950
Qard wants to merge 2 commits intonodejs:masterfrom
Qard:async-storage-eliminate-exit-transition

Conversation

@Qard
Copy link
Member

@Qard Qard commented Feb 25, 2020

The _exit logic is not actually necessary as explained here. This eliminates it and gives sync context runs a proper AsyncResource.

cc @vdeturckheim @puzpuzpuz @Flarna

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async_hooks Issues and PRs related to the async hooks subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants