Skip to content

src: Handle NULL env scenario#31899

Closed
HarshithaKP wants to merge 2 commits intonodejs:masterfrom
HarshithaKP:module_wrap_handle_null_ptr
Closed

src: Handle NULL env scenario#31899
HarshithaKP wants to merge 2 commits intonodejs:masterfrom
HarshithaKP:module_wrap_handle_null_ptr

Conversation

@HarshithaKP
Copy link
Member

Convert hard assertion into a throw with a useful error
message in src/module_wrap.cc

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants