stream: pipeline should use req.abort() to destroy response#31054
Closed
ronag wants to merge 4 commits intonodejs:masterfrom
Closed
stream: pipeline should use req.abort() to destroy response#31054ronag wants to merge 4 commits intonodejs:masterfrom
ronag wants to merge 4 commits intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
destroy(err) on http response will propagate the error to the
request causing 'error' to be unexpectedly emitted. Furthermore,
response.destroy() unlike request.abort() does not _dump buffered
data.
Fixes a breaking change applied in 6480882.
Prefer res.req.abort() over res.destroy() until this situation is
clarified.
This is a bugfix and I believe it should be semver minor.
Fixes #31029.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes