Skip to content

Break out platform delegate#30324

Closed
laverdet wants to merge 1 commit intonodejs:masterfrom
laverdet:platform-delegate
Closed

Break out platform delegate#30324
laverdet wants to merge 1 commit intonodejs:masterfrom
laverdet:platform-delegate

Conversation

@laverdet
Copy link
Contributor

@laverdet laverdet commented Nov 7, 2019 •
edited
Loading

This is continuation from the discussion here: laverdet/isolated-vm#133.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

+1 more reviewer

@lundibundi lundibundi lundibundi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. semver-major PRs that contain breaking changes and should be released in the next major version. v8 platform Issues and PRs related to Node's v8::Platform implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@laverdet @joyeecheung @addaleax @nodejs-github-bot @bnoordhuis @lundibundi