Skip to content

src: create HandleScope for env retrieval#30130

Closed
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
gabrielschulhof:missing-handle-scope
Closed

src: create HandleScope for env retrieval#30130
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
gabrielschulhof:missing-handle-scope

Conversation

@gabrielschulhof
Copy link
Contributor

Getting the current node::Environment using a
v8::Local<v8::Context> needs to be done within a v8::HandleScope.

Fixes: #30127

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finalizers are executed without a handle scope

7 participants