buffer: fix range checking for slowToString#2919
Closed
thefourtheye wants to merge 1 commit intonodejs:masterfrom
Closed
buffer: fix range checking for slowToString#2919thefourtheye wants to merge 1 commit intonodejs:masterfrom
thefourtheye wants to merge 1 commit intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion #2668,
this patch fixes the first problem discussed there. If
startis nota valid number in the range, then the default value zero will be used.
Same way, if
endis not a valid number in the accepted range, then,by default, the length of the buffer is assumed.
cc @trevnorris @ChALkeR