Skip to content

doc: deprecate finished#28679

Closed
ronag wants to merge 12 commits intonodejs:masterfrom
nxtedition:deprecate-finished
Closed

doc: deprecate finished#28679
ronag wants to merge 12 commits intonodejs:masterfrom
nxtedition:deprecate-finished

Conversation

@ronag
Copy link
Member

@ronag ronag commented Jul 14, 2019

Remove finished from docs. The naming and function is very confusing and misleading. What is finished is actually ended in the streams spec.

Refs: #28651

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeR ChALkeR ChALkeR left review comments

@mcollina mcollina mcollina approved these changes

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@addaleax addaleax Awaiting requested review from addaleax

@benjamingr benjamingr Awaiting requested review from benjamingr

+1 more reviewer

@dougwilson dougwilson dougwilson left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. http Issues or PRs related to the http subsystem. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.