Skip to content

repl: partially fix repl context#28561

Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR:partially-fix-repl-context
Closed

repl: partially fix repl context#28561
BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR:partially-fix-repl-context

Conversation

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Jul 5, 2019

This partially fixes contexts like {} instanceof Object === false
in the REPL. This does not fix all cases, since it's something
fundamental from the REPL's design that things like these can happen.

Refs: #27859

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants