Skip to content

Decorate crypto openssl errors with .code, .reason, ...#26868

Closed
sam-github wants to merge 2 commits intonodejs:masterfrom
sam-github:decorate-openssl-errors
Closed

Decorate crypto openssl errors with .code, .reason, ...#26868
sam-github wants to merge 2 commits intonodejs:masterfrom
sam-github:decorate-openssl-errors

Conversation

@sam-github
Copy link
Contributor

Crypto equivalent of this change to TLS: #25093

** crypto: add openssl specific error properties

Don't force the user to parse the long-style OpenSSL error message,
decorate the error with the library, reason, code, function.

** tls: return an OpenSSL error from renegotiate

A generic error lacks any of the context or detail of the underlying
OpenSSL error, so throw from C++, and report the OpenSSL error to the
callback.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-minor PRs that contain new features and should be released in the next minor version. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants