Skip to content

doc: edit "Using git-node" section of Guide#26580

Closed
Trott wants to merge 2 commits intonodejs:masterfrom
Trott:using-git-node
Closed

doc: edit "Using git-node" section of Guide#26580
Trott wants to merge 2 commits intonodejs:masterfrom
Trott:using-git-node

Conversation

@Trott
Copy link
Member

@Trott Trott commented Mar 11, 2019

Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

+4 more reviewers

@danbev danbev danbev approved these changes

@shisama shisama shisama approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@mihalskiy mihalskiy mihalskiy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Trott @nodejs-github-bot @vsemozhetbyt @danbev @cjihrig @richardlau @BethGriggs @shisama @mihalskiy