Skip to content

test: fix test-repl-envvars#25226

Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:test-repl-envvars-no-extend
Closed

test: fix test-repl-envvars#25226
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:test-repl-envvars-no-extend

Conversation

@addaleax
Copy link
Member

In 180f865, the test was changed
so that the env argument of createInternalRepl() also contained
external environment variables, because keeping them can be necessary
for spawning processes on some systems.

However, this test does not spawn new processes, and relies on the
fact that the environment variables it tests are not already set
(and fails otherwise); therefore, reverting to the original state
should fix this.

Fixes: #21451
Fixes: nodejs/build#1377
Refs: #25219

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 72 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AIX - tweak jenkins agent startup after reboot AIX failure after system mainteance.

9 participants