Skip to content

process: make internal/queue_microtask.js more self-contained#25189

Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung:queue-microtask
Closed

process: make internal/queue_microtask.js more self-contained#25189
joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung:queue-microtask

Conversation

@joyeecheung
Copy link
Member

  • Instead of passing triggerFatalException through node.js,
    simply put it on internalBinding('util') which has to be
    loaded anyway.
  • Expose the implementation of queueMicrotask directly instead
    of through an unnecessary factory function.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants