test,tools: move Flags: comment processing from Python to JavaScript#25167
Closed
Trott wants to merge 40 commits intonodejs:masterfrom
Closed
test,tools: move Flags: comment processing from Python to JavaScript#25167Trott wants to merge 40 commits intonodejs:masterfrom
Trott wants to merge 40 commits intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a big change set but one that can be broken down into many smaller pull requests for easier review if necessary.
This adds
common.relaunchWithFlags()along with two useful-but-not-strictly-necessary helper functions,common.exposeInternals()andcommon.experimentalWorker().This allows tests to relaunch themselves with the appropriate command line flags.
Advantages:
Downside:
make testwith this changeset took 5 minutes and 23 seconds. On master, it took 5 minutes and 16 seconds.Upside to the downside:
--expose-internals) could be a sign the test is testing the wrong thing.@nodejs/testing
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes