test: migrate process.binding to internalBinding for misc.#24952
Closed
BeniCheni wants to merge 12 commits intonodejs:masterfrom
BeniCheni:misc-process-to-internal-binding
Closed
test: migrate process.binding to internalBinding for misc.#24952BeniCheni wants to merge 12 commits intonodejs:masterfrom BeniCheni:misc-process-to-internal-binding
BeniCheni wants to merge 12 commits intonodejs:masterfrom
BeniCheni:misc-process-to-internal-binding
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #22160
For the migrated modules from the checklist of #22160, this PR identifies the places of source code & tests with "legacy"
process.binding, and follows up to migrate tointernalBinding.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes