Two URL parser fixes#24495

Closed

TimothyGu wants to merge 5 commits intonodejs:masterfrom

TimothyGu:url-flags

Member

TimothyGu commented Nov 19, 2018

This PR is an alternative to #24218 that resolves #24211 and #24345 without #24218's performance regression.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
~~documentation is changed or added~~
commit message follows commit guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fhinkel fhinkel approved these changes

jasnell jasnell approved these changes

addaleax addaleax approved these changes

watilde watilde approved these changes

cjihrig cjihrig approved these changes

joyeecheung joyeecheung approved these changes

BridgeAR BridgeAR approved these changes

+1 more reviewer

devsnek devsnek approved these changes

Labels

author ready c++ whatwg-url