net,dgram: add ipv6Only option for net and dgram#23798
Closed
oyyd wants to merge 1 commit intonodejs:masterfrom
Closed
net,dgram: add ipv6Only option for net and dgram#23798oyyd wants to merge 1 commit intonodejs:masterfrom
oyyd wants to merge 1 commit intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For our servers, the dual-stack support is enable by default, i.e. binding host "::" will also make "0.0.0.0" bound. This commit add ipv6Only option in
net.Server.listen(),net.Socket.connect()anddgram.createSocket()methods which allows to disable dual-stack support.Support for cluster module is also provided in this commit.
Fixes: #17664
/cc @silverwind
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes