Skip to content

tools,icu: read full ICU version info from file#23269

Merged
refack merged 1 commit intonodejs:masterfrom
refack:refactor-out-ICU-dep
Oct 12, 2018
Merged

tools,icu: read full ICU version info from file#23269
refack merged 1 commit intonodejs:masterfrom
refack:refactor-out-ICU-dep

Conversation

@refack
Copy link
Contributor

@refack refack commented Oct 4, 2018

ATM on every ICU version bump we need to update these data.
Reading it from a file makes it independant of configre.py changes.

Refs: #23245


Manual output:

D:\bin\dev\python27\python.exe configure.py --with-intl=full-icu --download=all
WARNING: * ECMA-402 (Intl) support didn't find ICU in deps/icu..
 <https://sourceforge.net/projects/icu/files/ICU4C/62.1/icu4c-62_1-src.zip>
 Fetch: | 24.1MB total, 24.1MB downloaded   
Checking file integrity with MD5:
MD5:      408854f7b9b58311b68fab4b4dfc80be  deps\icu4c-62_1-src.zip
 Extracting zipfile: deps\icu4c-62_1-src.zip
WARNING: warnings were emitted in the configure phase
Warning: Missing input files:
tools\msvs\genfiles\node_etw_provider.rc
tools\msvs\genfiles\node_etw_provider.h

Process finished with exit code 0
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants