Skip to content

src: improve SSL version extraction logic#23050

Closed
gireeshpunathil wants to merge 2 commits intonodejs:masterfrom
gireeshpunathil:ssl_version
Closed

src: improve SSL version extraction logic#23050
gireeshpunathil wants to merge 2 commits intonodejs:masterfrom
gireeshpunathil:ssl_version

Conversation

@gireeshpunathil
Copy link
Member

The openssl version as defined in ssl libraries is complex. The current logic to extract the major.minor.pacth format uses C semantics to loop through the text and search for specific patterns. Use C++ string to tidy it up.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.