Skip to content

http: Adding doc and debug for calling empty string on write function#22118

Closed
antsmartian wants to merge 1 commit intonodejs:masterfrom
antsmartian:22066
Closed

http: Adding doc and debug for calling empty string on write function#22118
antsmartian wants to merge 1 commit intonodejs:masterfrom
antsmartian:22066

Conversation

@antsmartian
Copy link
Contributor

@antsmartian antsmartian commented Aug 4, 2018

Addresses the issue : #22066

Removing the empty check would be a breaking change, however I'm not sure why such check is in first place. May be need input from the community.

In the meantime, I thought its worth to add documentation and at the same time to add debug log, so that when users feel write with empty string or buffer hangs, they can run in debug mode to find out the reason.

If the content fits for the documentation, I guess we need to add the same to http2 as well.

Open to feedbacks and thoughts.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants