http: Adding doc and debug for calling empty string on write function#22118
Closed
antsmartian wants to merge 1 commit intonodejs:masterfrom
Closed
http: Adding doc and debug for calling empty string on write function#22118antsmartian wants to merge 1 commit intonodejs:masterfrom
antsmartian wants to merge 1 commit intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the issue : #22066
Removing the empty check would be a breaking change, however I'm not sure why such check is in first place. May be need input from the community.
In the meantime, I thought its worth to add documentation and at the same time to add
debuglog, so that when users feelwritewith empty string or buffer hangs, they can run in debug mode to find out the reason.If the content fits for the documentation, I guess we need to add the same to
http2as well.Open to feedbacks and thoughts.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes