Skip to content

errors: fix ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK#21492

Closed
ChALkeR wants to merge 1 commit intonodejs:masterfrom
ChALkeR:doc-errcodes-restore-insthook
Closed

errors: fix ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK#21492
ChALkeR wants to merge 1 commit intonodejs:masterfrom
ChALkeR:doc-errcodes-restore-insthook

Conversation

@ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Jun 23, 2018

This restores a broken and erroneously removed error, which was accidentially renamed to ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK (notice the INTST vs INST) in 921fb84 (PR #16874) and then had documentation and implementation removed under the old name in 6e1c25c (PR #18857), as it appeared unused.

This error code never worked or was documented under the mistyped name
ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK, so renaming it back to
ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK is a semver-patch fix.

Refs: #21440, #21470, #16874, #18857.


This is a part of the fixes hinted by #21470, which includes some tests for error codes usage and documentation and enforces a stricter format.

This is mostly a revert, and specific tests for esm loader actually emitting that error are not included here.
Generic tests for error codes are included in a separate PR: #21470.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate Issues and PRs that are duplicates of other issues or PRs. errors Issues and PRs related to JavaScript errors originated in Node.js core. invalid Issues and PRs that are invalid.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants