Skip to content

inspector: allow concurrent inspector sessions#20137

Closed
eugeneo wants to merge 1 commit intonodejs:masterfrom
eugeneo:multy-client
Closed

inspector: allow concurrent inspector sessions#20137
eugeneo wants to merge 1 commit intonodejs:masterfrom
eugeneo:multy-client

Conversation

@eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Apr 18, 2018

This change enables concurrent inspector sessions, through WebSocket
interface as well as JS interface, in any combination.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott left review comments

+2 more reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@eugeneo @jasnell @Trott @ofrobots @addaleax @richardlau @bnoordhuis @TimothyGu @devsnek @nodejs-github-bot