Add a --preserve-symlinks-main option #19911
Closed
dgoldstein0 wants to merge 6 commits intonodejs:masterfrom
Closed
Add a --preserve-symlinks-main option #19911dgoldstein0 wants to merge 6 commits intonodejs:masterfrom
dgoldstein0 wants to merge 6 commits intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which behaves like --preserve-symlinks but for require.main. Fixes #19383
Checklist
I realize there is more to do here, but I wanted to send this out early for feedback. If there aren't any qualms with the approach, I'll figure out testing / documentation / etc.
make -j4 test(UNIX), orvcbuild test(Windows) passes