Skip to content

Add a --preserve-symlinks-main option #19911

Closed
dgoldstein0 wants to merge 6 commits intonodejs:masterfrom
dgoldstein0:master
Closed

Add a --preserve-symlinks-main option #19911
dgoldstein0 wants to merge 6 commits intonodejs:masterfrom
dgoldstein0:master

Conversation

@dgoldstein0
Copy link

@dgoldstein0 dgoldstein0 commented Apr 10, 2018

which behaves like --preserve-symlinks but for require.main. Fixes #19383

Checklist

I realize there is more to do here, but I wanted to send this out early for feedback. If there aren't any qualms with the approach, I'll figure out testing / documentation / etc.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants