http: use 'connect' event only if socket is connecting#16725

Closed

lpinca wants to merge 1 commit intonodejs:masterfrom

lpinca:gh-16716

Member

lpinca commented Nov 3, 2017

Fixes a bug that prevented ClientRequest.prototype.setTimeout() from
working properly when the socket was reused for multiple requests.

Fixes: #16716

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

http

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http