Skip to content

tools: auto fix custom eslint rule for prefer-assert-methods.js#16652

Closed
shobhitchittora wants to merge 2 commits intonodejs:masterfrom
shobhitchittora:pref-assert-methods-eslint-fixer
Closed

tools: auto fix custom eslint rule for prefer-assert-methods.js#16652
shobhitchittora wants to merge 2 commits intonodejs:masterfrom
shobhitchittora:pref-assert-methods-eslint-fixer

Conversation

@shobhitchittora
Copy link
Contributor

@shobhitchittora shobhitchittora commented Oct 31, 2017

This adds eslint fixer for auto-fixing the usage of assert operators. Also adding fileoverview for the perfer-assert-methods.js file.

For example the fixer change this assert(obj.value !== 9); to assert.notStrictEqual(obj.value, 9);

Refs: #16636

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
  • modify tests
Affected core subsystem(s)

Tools

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants