Skip to content

[v6.x backport] test: change deprecated method to recommended#14339

Closed
Trott wants to merge 1 commit intonodejs:v6.x-stagingfrom
Trott:backport-13649
Closed

[v6.x backport] test: change deprecated method to recommended#14339
Trott wants to merge 1 commit intonodejs:v6.x-stagingfrom
Trott:backport-13649

Conversation

@Trott
Copy link
Member

@Trott Trott commented Jul 18, 2017

In non-buffer tests, change usage of the Buffer constructor to one of
the recommended alternatives.

PR-URL: #13649
Reviewed-By: Refael Ackermann refack@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Brian White mscdex@mscdex.net

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants