net: multiple listen() events fail silently#13149
Closed
eduardbme wants to merge 1 commit intonodejs:masterfrom
Closed
net: multiple listen() events fail silently#13149eduardbme wants to merge 1 commit intonodejs:masterfrom
eduardbme wants to merge 1 commit intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
net
Description of change
Problem: It's possible to run listen() on a net.Server that's already listening to a port.
The result is silent failure, with the side effect of changing the _connectionKey and or _pipeName.
Solution: emit error if listen method called more than once.
close() method should be called between listen() method calls.
Refs: #8294
Fixes: #6190
Fixes: #11685
Previous PR #8419