Skip to content

src: expose V8's IsNativeError() in util bindings#12546

Merged
cjihrig merged 1 commit intonodejs:masterfrom
cjihrig:is-native-error
Apr 25, 2017
Merged

src: expose V8's IsNativeError() in util bindings#12546
cjihrig merged 1 commit intonodejs:masterfrom
cjihrig:is-native-error

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 20, 2017

Exposes IsNativeError() through process.binding('util'). The tests are copied from util.isError(). The results are the same with the exception of the last one (object inheriting from Error).

R= @addaleax because of #12400 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants