Skip to content

http: add type checking for hostname#12494

Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell:http-hostname-typechecking
Closed

http: add type checking for hostname#12494
jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell:http-hostname-typechecking

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Apr 18, 2017

Add type checking for options.hostname / options.host Maintains the use of undefined and null for default localhost, but other falsy values (like false, 0 and NaN) are rejected.

Refs: #12488

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http Issues or PRs related to the http subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants