Skip to content

src: only block SIGUSR1 when HAVE_INSPECTOR#12266

Closed
danbev wants to merge 1 commit intonodejs:masterfrom
danbev:test-signal-handler-failure
Closed

src: only block SIGUSR1 when HAVE_INSPECTOR#12266
danbev wants to merge 1 commit intonodejs:masterfrom
danbev:test-signal-handler-failure

Conversation

@danbev
Copy link
Contributor

@danbev danbev commented Apr 7, 2017

I'm currently seeing a timeout error for test-signal-handler.js on
macosx when using the following configuration:

./configure --debug --without-ssl && make -j8 test

--without-ssl implies that there will be no inspector but the signal
SIGUSR1 is blocked in PlatformInit just the same. But in this case
never unblocked which is causing the signal to never be delivered to
the handlers in test-signal-handler.js and it loops until it times out.

Not sure if this is the best way of fixing this but hopefully more eyes
on this will help.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol process Issues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants