Skip to content

deps: cherry-pick ca0f9573 from V8 upstream#11940

Closed
ofrobots wants to merge 1 commit intonodejs:v7.x-stagingfrom
ofrobots:arraybuffer-new-oom
Closed

deps: cherry-pick ca0f9573 from V8 upstream#11940
ofrobots wants to merge 1 commit intonodejs:v7.x-stagingfrom
ofrobots:arraybuffer-new-oom

Conversation

@ofrobots
Copy link
Contributor

Original commit message:

Trigger OOM crash if no memory returned in v8::ArrayBuffer::New and v…
…8::SharedArrayBuffer::New.

This API does not allow reporting failure, but we should crash rather than have
the caller get an ArrayBuffer that isn't properly set up.

BUG=chromium:681843

Review-Url: https://codereview.chromium.org/2641953002
Cr-Commit-Position: refs/heads/master@{#42511}

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps:v8

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants