Skip to content

test: fix process.title expectation#10597

Closed
thefourtheye wants to merge 1 commit intonodejs:masterfrom
thefourtheye:fix-process-title-check
Closed

test: fix process.title expectation#10597
thefourtheye wants to merge 1 commit intonodejs:masterfrom
thefourtheye:fix-process-title-check

Conversation

@thefourtheye
Copy link
Contributor

@thefourtheye thefourtheye commented Jan 3, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

process.title would work properly only in FreeBSD, OSX, and Linux as
per test/parallel/test-setproctitle.js.

This patch makes sure that the test expects an empty string in other
platforms.

This patch helps fix the SmartOS failures in
https://ci.nodejs.org/job/node-test-commit/6962/ for
#10456


cc @Trott

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants