Skip to content

test: improve the code in test-fs-read-stream#10556

Closed
edsadr wants to merge 1 commit intonodejs:masterfrom
edsadr:fs-read-stream
Closed

test: improve the code in test-fs-read-stream#10556
edsadr wants to merge 1 commit intonodejs:masterfrom
edsadr:fs-read-stream

Conversation

@edsadr
Copy link
Member

@edsadr edsadr commented Dec 31, 2016

  • use const and let instead of var
  • use common.mustCall to control function execution
  • use assert.strictEqual instead of assert.equal
  • use arrow functions
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants