node -p process.verions display issue on Windows Cmd

[nanixne]

{
node: �[32m'12.3.0'�[39m,
v8: �[32m'7.4.288.27-node.17'�[39m,
uv: �[32m'1.28.0'�[39m,
zlib: �[32m'1.2.11'�[39m,
brotli: �[32m'1.0.7'�[39m,
ares: �[32m'1.15.0'�[39m,
modules: �[32m'72'�[39m,
nghttp2: �[32m'1.38.0'�[39m,
napi: �[32m'4'�[39m,
llhttp: �[32m'1.1.3'�[39m,
http_parser: �[32m'2.8.0'�[39m,
openssl: �[32m'1.1.1b'�[39m,
cldr: �[32m'35.1'�[39m,
icu: �[32m'64.2'�[39m,
tz: �[32m'2019a'�[39m,
unicode: �[32m'12.1'�[39m
}

[vsemozhetbyt]

Can reproduce for v12.3.0 on Windows 7 x64 with cmd.exe. Output in the REPL is OK.

[richardlau]

12.2.0 also fails but 12.1.0 is okay.

{
  node: �[32m'12.2.0'�[39m,
  v8: �[32m'7.4.288.21-node.17'�[39m,
  uv: �[32m'1.28.0'�[39m,
  zlib: �[32m'1.2.11'�[39m,
  brotli: �[32m'1.0.7'�[39m,
  ares: �[32m'1.15.0'�[39m,
  modules: �[32m'72'�[39m,
  nghttp2: �[32m'1.38.0'�[39m,
  napi: �[32m'4'�[39m,
  llhttp: �[32m'1.1.3'�[39m,
  http_parser: �[32m'2.8.0'�[39m,
  openssl: �[32m'1.1.1b'�[39m,
  cldr: �[32m'35.1'�[39m,
  icu: �[32m'64.2'�[39m,
  tz: �[32m'2019a'�[39m,
  unicode: �[32m'12.1'�[39m
}

{
  node: '12.1.0',
  v8: '7.4.288.21-node.16',
  uv: '1.28.0',
  zlib: '1.2.11',
  brotli: '1.0.7',
  ares: '1.15.0',
  modules: '72',
  nghttp2: '1.38.0',
  napi: '4',
  llhttp: '1.1.1',
  http_parser: '2.8.0',
  openssl: '1.1.1b',
  cldr: '35.1',
  icu: '64.2',
  tz: '2019a',
  unicode: '12.1'
}

[BridgeAR]

I had a look at the changelog and I can't find anything obvious. Could someone verify that c2a03d58c3 has no impact? It seems the only entry that might have caused this? Otherwise it's probably best to bisected the commit.

[richardlau]

Latest nightly from master also fails:

{
  node: �[32m'13.0.0-nightly2019052247c5c3da86'�[39m,
  v8: �[32m'7.4.288.27-node.17'�[39m,
  uv: �[32m'1.29.1'�[39m,
  zlib: �[32m'1.2.11'�[39m,
  brotli: �[32m'1.0.7'�[39m,
  ares: �[32m'1.15.0'�[39m,
  modules: �[32m'72'�[39m,
  nghttp2: �[32m'1.38.0'�[39m,
  napi: �[32m'4'�[39m,
  llhttp: �[32m'1.1.3'�[39m,
  http_parser: �[32m'2.8.0'�[39m,
  openssl: �[32m'1.1.1b'�[39m,
  cldr: �[32m'35.1'�[39m,
  icu: �[32m'64.2'�[39m,
  tz: �[32m'2019a'�[39m,
  unicode: �[32m'12.1'�[39m
}

[richardlau]

Reverting 2b24ffa on master restores the expected behaviour. I'll open a revert PR.

[richardlau]

PR: #27823

[Fishrock123]

Can someone check if process._rawDebug(message) has the same effect in Windows CMD?

[joyeecheung]

Do you actually see colors in the original version of node -p?

[targos]

yes:

[joyeecheung]

@targos

Thanks. It seems we have to use uv_write for TTY on Windows so that libuv converts the color codes for us. I won't be near a Windows machine anytime soon, so I guess we could leave the patch reverted for now (or unless someone is willing to pick it up).

[bzoz]

we have to use uv_write for TTY on Windows so that libuv converts the color codes for us

That is exactly what is happening, ANSI codes are emulated on Windows with WinApi calls.