src,test: support V8 6.1 postmortem data#130
Merged
hhellyer merged 2 commits intonodejs:masterfrom Sep 8, 2017
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a work in progress, but adds postmortem debugging support for V8 6.1. The following issues still need to be resolved (all marked with
TODOin the code):Properly handle the end offset of function bodies. It previously needed to be shifted, but that is no longer the case. This just needs version detection logic.Properly load theThinStringTagconstant.V8DBG_THINSTRINGTAGappears to be defined, but the constant isn't loading. Right now, the value of0x5is hard coded.SupportUint8Arrays. Those tests are currently broken and commented out. The problem is that the backing store of theJSArrayBufferView'sJSArrayBufferis coming back as all zeros.UPDATE: The issue with the
Uint8Arrays is that the backing stores are not materialized. If the test is updated to reference the.bufferproperty, the backing store is materialized and shows up properly in llnode.