Skip to content

ansible: update benchmark/v8 roles for Ubuntu 24.04#4278

Draft
richardlau wants to merge 2 commits intonodejs:mainfrom
richardlau:benchmark-ubuntu2404
Draft

ansible: update benchmark/v8 roles for Ubuntu 24.04#4278
richardlau wants to merge 2 commits intonodejs:mainfrom
richardlau:benchmark-ubuntu2404

Conversation

@richardlau
Copy link
Member

Add role dependencies to the benchmarking role to ensure the user is created and github.com keys are present.

Add V8 build dependencies for Ubuntu 24.04.


Deployment

Add role dependencies to the `benchmarking` role to ensure the user
is created and github.com keys are present.

Add V8 build dependencies for Ubuntu 24.04.
@richardlau richardlau marked this pull request as draft March 18, 2026 18:16
@richardlau
Copy link
Member Author

Needs more work.

https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/770/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/console is failing with

18:30:28 Failed to fetch file gs://v8-wasm-spec-tests/daf4c75430122590992650885be9ee4e87692c5b for test/wasm-spec-tests/tests.tar.gz. [Err: Traceback (most recent call last):
18:30:28   File "/home/iojs/build/workspace/richardlau-node-test-commit-v8-linux/deps/v8/third_party/depot_tools/external_bin/gsutil/gsutil_4.68/gsutil/gsutil", line 21, in <module>
18:30:28     gsutil.RunMain()
18:30:28   File "/home/iojs/build/workspace/richardlau-node-test-commit-v8-linux/deps/v8/third_party/depot_tools/external_bin/gsutil/gsutil_4.68/gsutil/gsutil.py", line 121, in RunMain
18:30:28     import gslib.__main__
18:30:28   File "/home/iojs/build/workspace/richardlau-node-test-commit-v8-linux/deps/v8/third_party/depot_tools/external_bin/gsutil/gsutil_4.68/gsutil/gslib/__main__.py", line 36, in <module>
18:30:28     from six.moves import configparser
18:30:28 ModuleNotFoundError: No module named 'six.moves'
18:30:28 ]

which was seen in #4079 (comment) with Python 3.12 and solved by dropping down to Python 3.11.

@richardlau
Copy link
Member Author

Refs: https://issues.chromium.org/issues/40283283#comment49

FWIW depot_tools commit sha is in https://github.com/nodejs/node/blob/f68824a6805a82bd017004443430cf40c3efaf19/deps/v8/DEPS#L248-L249 and earlier than the gsutils update.

As a data point I'm running https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/771/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/ for nodejs/node#61898 and that appears to be working (or at least building).

We have got a problem though -- the default Python 3 on Ubuntu 24.04 is 3.12 and there does not appear to be a package for 3.11 so we cannot use an earlier version. And we still need to be able to run the V8 CI on e.g. Node.js 22 and 24.

@richardlau
Copy link
Member Author

As a data point I'm running https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/771/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/ for nodejs/node#61898 and that appears to be working (or at least building).

FTR this got as far as nodejs/node#61898 (comment) (that comment mentions GCC < 14 but we're using clang19 here and seeing the same issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant