fix size of modal-container

[szaimen]

Fix nextcloud/files_pdfviewer#843

• needs fix pdf-viewer sizing files_pdfviewer#845

[danxuliu]

The space at the bottom is explicitly added, and it is used by default for all handlers (even if it may be overriden later), so I do not think that clearing it to fix the PDF viewer is the right approach (but please note that I have not actually checked how this change affects other handlers).

Moreover, that bottom space has been there since Nextcloud 25 and it only started to be a problem in the PDF viewer in Nextcloud 28.

Please refer to nextcloud/files_pdfviewer#843 (comment) for an explanation of the issue. Unfortunately I am not sure of what would be a good solution 🤔

[szaimen]

The space at the bottom is explicitly added, and it is used by default for all handlers (even if it may be overriden later), so I do not think that clearing it to fix the PDF viewer is the right approach (but please note that I have not actually checked how this change affects other handlers).

Moreover, that bottom space has been there since Nextcloud 25 and it only started to be a problem in the PDF viewer in Nextcloud 28.

Please refer to nextcloud/files_pdfviewer#843 (comment) for an explanation of the issue. Unfortunately I am not sure of what would be a good solution 🤔

I chose this solution because for me it doesnt make sense from design perspective to enforce the space on the bottom. WDYT @nextcloud/designers?

[skjnldsv]

I chose this solution because for me it doesnt make sense from design perspective

Visual balance! It looks weird if the top spacing isn't matching the bottom one. This was seen and requested by the design team in the past.
Maybe let's not ping the whole design team for a previously taken decision? 🤷

With	Without

[szaimen]

Visual balance! It looks weird if the top spacing isn't matching the bottom one. This was seen and requested by the design team in the past. Maybe let's not ping the whole design team for a previously taken decision? 🤷

With Without

You are right. I guess we need to find a different solution then in pdf viewer...

[szaimen]

Actually found an easy fix in the pdfviewer: nextcloud/files_pdfviewer#845