Fix video player unusable on ios

[hamza221]

fixes #1681

• Test For regressions on Other phones and web
  Before in the comments
  
  
  
  

[JuliaKirschenheuter]

Thank you @hamza221 a lot! Looks much better as before!

Just some checkpoints from the ticket:

• the full screen is not working, it’s just a window that loses all controls (play, pause, get back to windowed mode)

• seems to be fixed, right?

• when in full screen, you basically can’t do anything anymore, I just quit the application (firefox or safari) to stop the video.

• seems to be fixed, right?

• when turning the phone from portrait to landscape, the video disappear behind the title bar.

• could you please test it in a moment?

I'm not sure about this landscape portrait view:

Is it possible to move a video a bit down?

Thanks a lot again!

[hamza221]

For the last point I think we need a design decision, because the footer is taking the space. so we either remove the footer, keep it slightly hidden, make the footer shorter or another option I didn't think of

[JuliaKirschenheuter]

Thanks! I guess it is better to hide a footer at all for landscape and portrait full screen view. Logo of nextcloud is on top left and it is a full screen mode. @marcoambrosini could you please give us your opinion?

[marcoambrosini]

I think that in fullscreen view both the header and the footer should not be visible and the viewer should take the whole height of the screen

[hamza221]

[JuliaKirschenheuter]

Thanks a lot!

[st3iny]

Tested my changes on an iPad (Safari).

[artonge]

The solution seems saner. 👍
Can you add a bit more context and info around the issue and what the screenshots represent?

[JuliaKirschenheuter]

Node and Lint are failing ;(
@st3iny could you please fix them too?

[st3iny]

I fixed linter issues and the node check. I don't know what is going on with Cypress though.

[AndyScherzinger]

/backport to stable27

[AndyScherzinger]

/backport to stable26

[AndyScherzinger]

/backport to stable25

[AndyScherzinger]

Approval are now in from Artonge and St3iny, cypress failures seem unrelated. Rebased to be merged afterwards, backports triggered

[backportbot-nextcloud]

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[backportbot-nextcloud]

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[backportbot-nextcloud]

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[skjnldsv]

Approval are now in from Artonge and St3iny, cypress failures seem unrelated. Rebased to be merged afterwards, backports triggered

ok for those tests yes, they nedd an update to not randomly fail