Improving Voice Messages after ChatKit removal#6033
Improving Voice Messages after ChatKit removal#6033rapterjet2004 wants to merge 1 commit intomasterfrom
Conversation
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/24093383370/artifacts/6310944748 |
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/24141097078/artifacts/6330150995 |
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/24142522709/artifacts/6330568557 |
655db8c to
f52af5a
Compare
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/24193330893/artifacts/6351427476 |
There was a problem hiding this comment.
Pull request overview
This PR replaces the legacy AndroidView-based waveform seek bar used for voice messages with a Jetpack Compose implementation, aligning the voice-message UI with the post-ChatKit architecture and reducing reliance on View interop.
Changes:
- Added a new
ComposeWaveformSeekBarcomposable that draws a waveform track and custom thumb. - Updated
VoiceMessageto use the Compose waveform slider instead ofWaveformSeekBar+AndroidView, and to shrink waveform data to a fixed bar count. - Minor import reordering in
ChatMessageUi.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
app/src/main/java/com/nextcloud/talk/ui/ComposeWaveformSeekbar.kt |
Introduces a Compose slider with custom track drawing for waveform rendering. |
app/src/main/java/com/nextcloud/talk/ui/chat/VoiceMessage.kt |
Switches voice-message seeking UI from AndroidView to the new Compose waveform seek bar. |
app/src/main/java/com/nextcloud/talk/chat/ui/model/ChatMessageUi.kt |
Import ordering cleanup (no behavioral change). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f52af5a to
904cd45
Compare
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/24247099827/artifacts/6373075578 |
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/24249845619/artifacts/6373922090 |
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/24255816609/artifacts/6376472969 |
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
257feb5 to
d656633
Compare
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/24350277710/artifacts/6408701616 |
Demo
Screen_recording_20260413_093307.webm
🚧 TODO
🏁 Checklist
/backport to stable-xx.x