Skip to content

Improving Voice Messages after ChatKit removal#6033

Open
rapterjet2004 wants to merge 1 commit intomasterfrom
issue-6019-waveform-compose
Open

Improving Voice Messages after ChatKit removal#6033
rapterjet2004 wants to merge 1 commit intomasterfrom
issue-6019-waveform-compose

Conversation

@rapterjet2004
Copy link
Copy Markdown
Contributor

@rapterjet2004 rapterjet2004 commented Apr 7, 2026


  • Improved the previous implementation, by adding a short animation upon loading the waveform data.

Demo

Screen_recording_20260413_093307.webm

🚧 TODO

  • Implement Waveform seekbar in Jetpack Compose
  • Fix interactivity issues

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Apr 7, 2026
@rapterjet2004 rapterjet2004 added the 2. developing Work in progress label Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24093383370/artifacts/6310944748
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24141097078/artifacts/6330150995
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24142522709/artifacts/6330568557
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@rapterjet2004 rapterjet2004 force-pushed the issue-6019-waveform-compose branch from 655db8c to f52af5a Compare April 9, 2026 13:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24193330893/artifacts/6351427476
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces the legacy AndroidView-based waveform seek bar used for voice messages with a Jetpack Compose implementation, aligning the voice-message UI with the post-ChatKit architecture and reducing reliance on View interop.

Changes:

  • Added a new ComposeWaveformSeekBar composable that draws a waveform track and custom thumb.
  • Updated VoiceMessage to use the Compose waveform slider instead of WaveformSeekBar + AndroidView, and to shrink waveform data to a fixed bar count.
  • Minor import reordering in ChatMessageUi.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.

File Description
app/src/main/java/com/nextcloud/talk/ui/ComposeWaveformSeekbar.kt Introduces a Compose slider with custom track drawing for waveform rendering.
app/src/main/java/com/nextcloud/talk/ui/chat/VoiceMessage.kt Switches voice-message seeking UI from AndroidView to the new Compose waveform seek bar.
app/src/main/java/com/nextcloud/talk/chat/ui/model/ChatMessageUi.kt Import ordering cleanup (no behavioral change).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rapterjet2004 rapterjet2004 force-pushed the issue-6019-waveform-compose branch from f52af5a to 904cd45 Compare April 10, 2026 14:09
@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/24247099827/artifacts/6373075578
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/24249845619/artifacts/6373922090
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/24255816609/artifacts/6376472969
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 rapterjet2004 force-pushed the issue-6019-waveform-compose branch from 257feb5 to d656633 Compare April 13, 2026 14:56
@github-actions
Copy link
Copy Markdown
Contributor

Codacy

Lint

TypemasterPR
Warnings8888
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5353
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8080

@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/24350277710/artifacts/6408701616
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve voice messages

2 participants