Skip to content

Allow to force enable apps via CLI#17018

Merged
nickvergessen merged 1 commit intomasterfrom
feature/noid/allow-to-force-enable-via-cli
Dec 16, 2019
Merged

Allow to force enable apps via CLI#17018
nickvergessen merged 1 commit intomasterfrom
feature/noid/allow-to-force-enable-via-cli

Conversation

@nickvergessen
Copy link
Copy Markdown
Member

@nickvergessen nickvergessen commented Sep 5, 2019

Steps

  1. Check out master of server
  2. Check out stable17 of activity app
  3. Try to enable it via CLI, to fix it for master 💥

The UI had the red button to force enable it. This is now possible via:
occ app:enable activity --force

cc @jancborchardt should help you a lot

@nickvergessen nickvergessen added this to the Nextcloud 18 milestone Sep 5, 2019
@nickvergessen nickvergessen force-pushed the feature/noid/allow-to-force-enable-via-cli branch from 5a48784 to 1baeef8 Compare September 5, 2019 13:15
@kesselb
Copy link
Copy Markdown
Contributor

kesselb commented Sep 5, 2019

TypeError: Argument 2 passed to OC\App\AppManager::__construct() must implement interface OCP\IConfig, instance of Mock_AppConfig_4eb7dda7 given, called in /drone/src/tests/lib/App/AppManagerTest.php on line 114

Nice to have: A test case for tests/Core/Command/Apps/AppsEnableTest.php but a incompatible fake app might be required.

This was referenced Dec 11, 2019
Merged
Merged
@ChristophWurst ChristophWurst force-pushed the feature/noid/allow-to-force-enable-via-cli branch from 1baeef8 to 05102d7 Compare December 13, 2019 11:14
@ChristophWurst
Copy link
Copy Markdown
Member

ChristophWurst commented Dec 13, 2019

rebased, squashed and tests fixed :)

georgehrke
georgehrke approved these changes Dec 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 13, 2019
@blizzz
Copy link
Copy Markdown
Member

blizzz commented Dec 13, 2019

TypeError: Argument 2 passed to OC\App\AppManager::__construct() must implement interface OCP\IConfig, instance of Mock_AppConfig_5b004e91 given, called in /drone/src/tests/lib/AppTest.php on line 556

@nickvergessen @ChristophWurst
Allow to force enable apps via CLI
3eee359 
Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the feature/noid/allow-to-force-enable-via-cli branch from 05102d7 to 3eee359 Compare December 13, 2019 12:06
@nickvergessen nickvergessen merged commit faf58e4 into master Dec 16, 2019
@nickvergessen nickvergessen deleted the feature/noid/allow-to-force-enable-via-cli branch December 16, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georgehrke georgehrke georgehrke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@blizzz blizzz Awaiting requested review from blizzz

@gary-kim gary-kim Awaiting requested review from gary-kim

@bergart bergart Awaiting requested review from bergart

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: apps management

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen @kesselb @ChristophWurst @blizzz @georgehrke @skjnldsv