Footer height in public view too small if imprint/privacy link set

[Chartman123]

Currently the footer-height is set to 65px:

server/core/css/public.scss

Line 1 in b739dd5

$footer-height: 65px;

This is too small if the imprint/privacy links are set in the settings of the instance and text gets cut off. (see nextcloud/forms#1337)

If links are set a better value would be 95px.

[Chartman123]

Also here in css:

server/core/css/public.css

Line 56 in b739dd5

height: 65px;

[suselunarwolf]

HI,I'm willing to work on it.

[RyanAveritt]

@suselunarwolf are you still working on this issue?

[RyanAveritt]

@Chartman123 would this be a dynamic change only changing when there are links set in the settings that affect the footer?

[Chartman123]

@jancborchardt what do you think? Should the footer height be dynamically adjusted if one of the links is set?

[RyanAveritt]

Also, I am a bit lost on testing it myself if we do want it dynamically adjusted; should I go to the forums for advice or may I ask here? (I have the dev environment for forms cloned but am unsure how to add links to the footer)

[Chartman123]

@RyanAveritt it's not only Forms related, but you can of course check it there. You have to go to the Settings of your Nextcloud instance and then to the Theming settings... There you can set the links :)

[RyanAveritt]

Maybe because of my setup but I now can test it if the decision is made to go dynamic; if we do go dynamic, do you have any tips on where to listen for the "event" and changing the size (Sorry if this is asking a lot; first-time contributor)?

Also, thank you for the feedback @Chartman123.

[RyanAveritt]

Does omitting the height in body-public footer for core/css/server.css fix it?
See

server/core/css/server.css

Line 5005 in 754cef3

height: 65px;