Conversation
b146d4d to
5b74d30
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
cac5f43 to
56769cd
Compare
eszkadev
left a comment
There was a problem hiding this comment.
Tested regular case (not WASM): works as expected, downloading the files work
I don't have setup for WASM
Ashod
left a comment
There was a problem hiding this comment.
Thanks @juliushaertl.
Looks good to me. @caolanm, any concerns?
|
no concerns, this seems to give us what we want without disrupting existing setups |
mejo-
left a comment
There was a problem hiding this comment.
No idea about wasm, but code changes look sensible.
which was added in: CollaboraOnline/online#7784 Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
56769cd to
571472e
Compare
|
Amended a small change to only set the allowEvalWasm if wasm support is indicated by the capabilities. |
|
yes, sensible |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
These headers are added to all Nextcloud apps by richdocuments which causes the News app to fail to show feed icons. I solved this by commenting out that part of richdocuments but that's a crude hack. These headers should only be inserted when the richdocuments app is active and in use in the current session, not when other apps are in the foreground. As to how to achieve this I have not found a good solution yet but maybe I'm overlooking something? |
|
Can you please file a new issue about this? It could be that we apply those too widely. Just a sidenote: Wouldn't it be better to fetch the icons on the backend and cache them on the Nextcloud side? That way the request would be also hiding the individual user ips and avoid loading remote content directly. |
Uh oh!
There was an error while loading. Please reload this page.