Update FolderTagPreview.vue#649
Closed
DeJQit wants to merge 4 commits intonextcloud:masterfrom
DeJQit:patch-1
Closed
Update FolderTagPreview.vue#649DeJQit wants to merge 4 commits intonextcloud:masterfrom DeJQit:patch-1
DeJQit wants to merge 4 commits intonextcloud:masterfrom
DeJQit:patch-1
Conversation
This implementation provides the following UI improvement: * Multi-line text beside folder icon Signed-off-by: Alex Chernega <sasha.chernega@gmail.com>
* Multi-line text beside folder icon
* Multi-line text beside folder icon Signed-off-by: Alex Chernega <sasha.chernega@gmail.com>
Signed-off-by: Alex Chernega <sasha.chernega@gmail.com>
Member
|
Hey! cc @jancborchardt for design validation |
victormgarciao
approved these changes
Feb 25, 2021
Member
|
@jancborchardt can you review this design-wise? |
Member
|
I think this should be limited to two lines. That would yield the maximum of design and legibility, IMO. |
Member
|
Agree with @marcelklehr on limiting it to 2 lines. And line-height needs to be higher here, ideally it is somewhere between 130%–150% (best use percentage values). |
Member
Line clamp is widely supported now, but still a draft |
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
Member
|
Updated in 25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation provides the following UI improvement: