Skip to content

Fix Firefox & Edge18 transpiling issues#294

Merged
skjnldsv merged 1 commit intomasterfrom
fix/transpiling
Apr 18, 2020
Merged

Fix Firefox & Edge18 transpiling issues#294
skjnldsv merged 1 commit intomasterfrom
fix/transpiling

Conversation

@skjnldsv
Copy link
Copy Markdown
Member

@skjnldsv skjnldsv commented Apr 18, 2020 •
edited
Loading

Fix #293

Test archive photos.tar.gz

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Apr 18, 2020
@skjnldsv skjnldsv added this to the Nextcloud 19 milestone Apr 18, 2020
@skjnldsv skjnldsv self-assigned this Apr 18, 2020
@skjnldsv skjnldsv mentioned this pull request Apr 18, 2020
Closed
@skjnldsv
Copy link
Copy Markdown
Member Author

skjnldsv commented Apr 18, 2020

/compile amend /

@skjnldsv
Copy link
Copy Markdown
Member Author

skjnldsv commented Apr 18, 2020

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Apr 18, 2020
@skjnldsv
Copy link
Copy Markdown
Member Author

skjnldsv commented Apr 18, 2020

/compile amend /

@skjnldsv
Fix Firefox & Edge18 transpiling issues
2db1164 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@skjnldsv skjnldsv merged commit f103378 into master Apr 18, 2020
@skjnldsv skjnldsv deleted the fix/transpiling branch April 18, 2020 15:14
@roadfox
Copy link
Copy Markdown

roadfox commented Apr 18, 2020

Thats much better, many thanks.
In Edge it looks perfect. In Firefox the thumbnails are NOT sharp, see attached Screenshot, Firefox on the Left, Edge on the right:

grafik

@backportbot-nextcloud
Copy link
Copy Markdown

backportbot-nextcloud bot commented Apr 18, 2020

The backport to stable18 failed. Please do this backport manually.

@roadfox
Copy link
Copy Markdown

roadfox commented Apr 18, 2020

Just verified in Chrome (Version 81.0.4044.113 (Offizieller Build) (64-Bit)) there the Thumbnails are also not sharp

@skjnldsv skjnldsv mentioned this pull request Apr 18, 2020
Merged
@skjnldsv
Copy link
Copy Markdown
Member Author

skjnldsv commented Apr 18, 2020

In Firefox the thumbnails are NOT sharp

Hey!
Sorry about that, the test version I shipped also included some code I was testing out. This was not part of this pull request though! So all good 🤗

Thanks for testing!!

@skjnldsv
Copy link
Copy Markdown
Member Author

skjnldsv commented Apr 18, 2020

@roadfox you can test by using the latest master zip: https://github.com/nextcloud/photos/archive/master.zip

@roadfox
Copy link
Copy Markdown

roadfox commented Apr 18, 2020

looks perfect now in all three browsers, many thanks

@rullzer rullzer mentioned this pull request Apr 21, 2020
Merged
55 tasks
@skjnldsv skjnldsv removed the backport-request Pending backport by the backport-bot label Apr 22, 2020
@jancborchardt
Copy link
Copy Markdown
Member

jancborchardt commented Apr 22, 2020

@acsfer can you confirm this is fixed for you as well? I’m still experiencing the issue with latest master it seems.

@e-alfred
Copy link
Copy Markdown

e-alfred commented Apr 24, 2020 •
edited
Loading

It seems like panoramic pictures are not shown as sharp images in Firefox except in the preview image (which is cropped). In Chrome they look okay.

@solracsf
Copy link
Copy Markdown
Member

solracsf commented Apr 24, 2020

@jancborchardt yes, fixed in 19beta5 for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

Blank Page after upgrade from 18latest to 19beta4

5 participants

@skjnldsv @roadfox @jancborchardt @e-alfred @solracsf