Re: [nextcloud/files_pdfviewer] Last Page of PDF cut off on Android Mobile (Issue #660)

[orangkucing]

PDFView.vue is patched to set vertical size correctly.

[danxuliu]

Thanks for your contribution!

I still need to take a deeper look to the fix, but from a quick test it looks promising :-)

However, some changes would be needed before merging it. Right now:

• as the two commits are interrelated they should be squashed into a single one
• the commit message should be adjusted to be descriptive of the change
• the unneeded code should be removed rather than commented
• the existing rule for height should be modified rather than overriden with an additional one.

Also please note that further changes might be needed (or not) once I do a deeper review (which might take a while, sorry about that).

Would you like to do those changes yourself, or would you prefer me to take over and do them?

Thanks!

[orangkucing]

I prefer you to take over and do them. Thanks.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[danxuliu]

I am very sorry for the long long delay. Please accept my apologies.

I was finally able to investigate this issue in deep and found that, while using dvh works, it would be better to base the height of the PDF viewer on the height of its parent. Therefore I opened another pull request that should also fix the issue, but adjusted to the latest changes in the code and, hopefully, in a more "future-proof" way: #1227 Reviews are welcome :-)

I will then close this pull request, but thanks for your time and working on a fix, and sorry again for the long delay.