Skip to content

[stable8] fix(NcRichText): ignore links resolving in Markdown#8302

Merged
susnux merged 2 commits intostable8from
backport/8154/stable8
Mar 13, 2026
Merged

[stable8] fix(NcRichText): ignore links resolving in Markdown#8302
susnux merged 2 commits intostable8from
backport/8154/stable8

Conversation

@backportbot
Copy link
Copy Markdown

@backportbot backportbot bot commented Mar 13, 2026

Backport of #8154

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from Antreesy, ShGKme and susnux March 13, 2026 10:35
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Mar 13, 2026
@backportbot backportbot bot added this to the 8.37.0 milestone Mar 13, 2026
- it's already a part of remark-gfm

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the backport/8154/stable8 branch from dd03d2d to 573c1a9 Compare March 13, 2026 10:46
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.85%. Comparing base (780c374) to head (bde964c).
⚠️ Report is 3 commits behind head on stable8.

Files with missing lines Patch % Lines
src/components/NcRichText/remarkStripCode.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           stable8    #8302      +/-   ##
===========================================
- Coverage    45.88%   45.85%   -0.04%     
===========================================
  Files          193      194       +1     
  Lines         4886     4892       +6     
  Branches      1200     1200              
===========================================
+ Hits          2242     2243       +1     
- Misses        2558     2563       +5     
  Partials        86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- for links in markdown objects references should not be rendered
- This affects rendered `code` and `pre` blocks
- Content of mentioned should be ignored from testing against URL_PATTERN RegExp and sending with a server request to extract references.

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the backport/8154/stable8 branch from 573c1a9 to bde964c Compare March 13, 2026 10:56
@Antreesy Antreesy marked this pull request as ready for review March 13, 2026 11:00
Copy link
Copy Markdown
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy Antreesy mentioned this pull request Mar 13, 2026
Copy link
Copy Markdown
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise fine

@susnux susnux merged commit 8a78880 into stable8 Mar 13, 2026
22 of 24 checks passed
@susnux susnux deleted the backport/8154/stable8 branch March 13, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: richtext Related to the richtext component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants