Skip to content

fix(NcModal): properly handle modal name size#8263

Merged
susnux merged 1 commit intomainfrom
fix/nc-modal-title
Mar 2, 2026
Merged

fix(NcModal): properly handle modal name size#8263
susnux merged 1 commit intomainfrom
fix/nc-modal-title

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented Feb 27, 2026

☑️ Resolves

  • When the width is small the name must be ellipsed and not overflow any action (e.g. the play buttton!).
  • The name must be centered if wide enough (it was not because padding was incorrectly calculated).

🖼️ Screenshots

Bildschirmaufnahme_20260227_163610.webm

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

- When the width is small the name must be ellipsed and not overflow any
  action (e.g. the play buttton!).
- The name must be centered if wide enough (it was not because padding
  was incorrectly calculated).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the 9.6.0 milestone Feb 27, 2026
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: modal Related to the modal component labels Feb 27, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.75%. Comparing base (81c5924) to head (632e71b).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
src/components/NcModal/NcModal.vue 20.00% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8263      +/-   ##
==========================================
- Coverage   52.84%   52.75%   -0.10%     
==========================================
  Files         103      103              
  Lines        3351     3361      +10     
  Branches      977      979       +2     
==========================================
+ Hits         1771     1773       +2     
- Misses       1332     1337       +5     
- Partials      248      251       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Feb 27, 2026

/backport to stable8

Copy link
Copy Markdown
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from the deployed page

Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux susnux merged commit 637161e into main Mar 2, 2026
25 of 27 checks passed
@susnux susnux deleted the fix/nc-modal-title branch March 2, 2026 14:53
@susnux susnux mentioned this pull request Mar 13, 2026
@susnux susnux self-assigned this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: modal Related to the modal component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants