Skip to content

Bring back label outside of the input for NcActionInput#4484

Merged
Pytal merged 1 commit intomasterfrom
bugfix/ncactioninput-label-outside
Aug 30, 2023
Merged

Bring back label outside of the input for NcActionInput#4484
Pytal merged 1 commit intomasterfrom
bugfix/ncactioninput-label-outside

Conversation

@juliusknorr
Copy link
Copy Markdown
Contributor

@juliusknorr juliusknorr commented Aug 30, 2023 •
edited
Loading

#4394 introduced a change that having the label outside of the input is no longer possible with NcActionItem

In previous versions the label was shown above the input which gives the
text more space which might be better than the inline label from
https://github.com/nextcloud-libraries/nextcloud-vue/pull/4394 in some
scenarios.

This is a breaking change as it renames the previous labelVisible
property to a labelOutside property. The label should always be visible
with the new NcInputField, however we can optionally decide to have the
label outside.

Found in nextcloud/text#4663

🖼️ Screenshots

7.x.x with label-visible

Screenshot 2023-08-30 at 08 35 21

Current 8.0.0-beta.with label-visible

Screenshot 2023-08-30 at 08 35 37

This PR with label-outside

Screenshot 2023-08-30 at 08 36 05

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@juliusknorr
fix!(NcActionInput): Fix option to have the label next to the input f…
d0fcc24 
…ield

In previous versions the label was shown above the input which gives the
text more space which might be better than the inline label from
#4394 in some
scenarios.

This is a breaking change as it renames the previous labelVisible
property to a labelOutside property. The label should always be visible
with the new NcInputField, however we can optionally decide to have the
label outside.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/ncactioninput-label-outside branch from fe4f363 to d0fcc24 Compare August 30, 2023 06:38
@juliusknorr juliusknorr added enhancement New feature or request 3. to review Waiting for reviews labels Aug 30, 2023
@juliusknorr juliusknorr added this to the 8.0.0 milestone Aug 30, 2023
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 30, 2023
@Pytal Pytal merged commit bdab171 into master Aug 30, 2023
@Pytal Pytal deleted the bugfix/ncactioninput-label-outside branch August 30, 2023 17:21
@Pytal Pytal mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

+1 more reviewer

@Pytal Pytal Pytal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr @Pytal @ShGKme