Skip to content

[code-infra] Migrate to ESLint 10#21733

Open
brijeshb42 wants to merge 1 commit intomui:masterfrom
brijeshb42:eslint-10
Open

[code-infra] Migrate to ESLint 10#21733
brijeshb42 wants to merge 1 commit intomui:masterfrom
brijeshb42:eslint-10

Conversation

@brijeshb42
Copy link
Contributor

Changes made -

package.json:

  • Added "@eslint/compat": "^2.0.2" — needed for fixupPluginRules to wrap plugins not yet compatible with ESLint 10
  • Updated "eslint" to latest v10
  • Added pnpm.peerDependencyRules.allowedVersions for eslint: "10" to suppress peer dependency warnings from plugins that haven't officially added ESLint 10 support yet. We can live without it as well, just that some peerdep warnings will be logged.

eslint.config.mjs:

  • Wrapped both consistent-default-export-name plugin registrations with fixupPluginRules() for ESLint 10 compatibility
  • Added next: { rootDir: 'docs' } to the settings block which next.js's eslint plugin was complaining about

.lintignore:

  • Added /examples — examples ideally should have their own eslint config and should not be dictated by the same rules as the rest of the repo.

@brijeshb42 brijeshb42 requested review from a team and LukasTy March 13, 2026 08:52
@brijeshb42 brijeshb42 added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). labels Mar 13, 2026
@brijeshb42 brijeshb42 requested review from a team and removed request for LukasTy March 13, 2026 08:53
@mui-bot
Copy link

mui-bot commented Mar 13, 2026

Deploy preview: https://deploy-preview-21733--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against a351282

Changes made -

package.json:

- Added "@eslint/compat": "^2.0.2" — needed for fixupPluginRules to wrap
plugins not yet compatible with ESLint 10
- Updated "@mui/internal-code-infra" from 0.0.4-canary.0 →
0.0.4-canary.5 — contains ESLint 10 compatibility fixes
- Updated "eslint" from 9.39.2 → 10.0.3
- Added pnpm.peerDependencyRules.allowedVersions for eslint: "10" to
suppress peer dependency warnings from plugins that haven't officially
added ESLint 10 support yet

eslint.config.mjs:

- Added import { fixupPluginRules } from '@eslint/compat';
- Wrapped both consistent-default-export-name plugin registrations with
fixupPluginRules() for ESLint 10 compatibility
- Added next: { rootDir: 'docs' } to the settings block (matching the
material-ui change)

.lintignore:

- Added /examples — examples have their own ESLint configs and
dependencies

pnpm-lock.yaml:

- Updated lockfile reflecting all dependency changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👌

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: out-of-date The pull request has merge conflicts and can't be merged. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants