[data-grid] Fix DataGrid cell text vertical alignment#21731
Draft
aman44444 wants to merge 3 commits intomui:masterfrom
Draft
[data-grid] Fix DataGrid cell text vertical alignment#21731aman44444 wants to merge 3 commits intomui:masterfrom
aman44444 wants to merge 3 commits intomui:masterfrom
Conversation
|
Deploy preview: https://deploy-preview-21731--material-ui-x.netlify.app/ Bundle size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mui/material-ui#47118
Root cause
Cells currently rely on line-height to vertically center text:
line-height: calc(var(--height) - 1px)This couples vertical alignment to typography. When line-height changes through theme or font settings, text alignment becomes inconsistent and the selection highlight fills the entire cell height instead of the text line.
Fix
Replace line-height centering with flex alignment:
Since text-overflow: ellipsis breaks when the cell becomes a flex container, direct string content is wrapped in a span and flex children are allowed to shrink so truncation works correctly.
Tested
Verified on the docs site with:
sorting
row selection
cell editing
pinned columns
long text with ellipsis
I have followed (at least) the PR section of the contributing guide.