Utility: (attempt to) use a Clang 14+ pragma for CORRADE_DEPRECATED_MACRO()#207
Draft
Utility: (attempt to) use a Clang 14+ pragma for CORRADE_DEPRECATED_MACRO()#207
Conversation
Well, except that the way I'm using it doesn't really work, it would need to be a standalone declaration independent from the macro definition itself. Which ... makes it pretty much useless, sigh. The original proposal at https://reviews.llvm.org/D67935 implemented an approach that's exactly matching my use case, but the final version at llvm/llvm-project@26c695b doesn't seem to support that anymore, and is thus impossible to be wrapped in a compiler-independent macro. Sigh.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #207 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 143 143
Lines 13283 13283
=======================================
Hits 13051 13051
Misses 232 232 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, except that the way I'm using it doesn't really work, it would need to be a standalone declaration independent from the macro definition itself. Which ... makes it pretty much useless, sigh.
The original proposal at https://reviews.llvm.org/D67935 implemented an approach that's exactly matching my use case, but the final version at llvm/llvm-project@26c695b doesn't seem to support that anymore, and is thus impossible to be wrapped in a compiler-independent macro. Sigh.